Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable router-links for pending and declined shares #10097

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

JammingBen
Copy link
Collaborator

Description

This is only a temporary fix until those shares can be accessed properly, which will be possible with the new sharing NG. No unit tests added because of that.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

This is only a temporary fix until those shares can be accessed properly, which will be possible with the new sharing NG.
@JammingBen JammingBen self-assigned this Nov 30, 2023
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

sonarcloud bot commented Nov 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@JammingBen JammingBen merged commit 340ea48 into master Nov 30, 2023
4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the disable-router-links-for-pending-declined-shares branch November 30, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable router-links for pending and declined shares on shared with me
2 participants